feat: Support for asynchronous getLoadContext
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogadra
changed the title
getLoadContextgetLoadContext
Owner
|
Hi @ogadra Thank you for the PR! @predaytor Will this solve your problem? Can you review this? |
|
@yusukebe yeah! except we also need to check the promise in dev script at app.all('*', async (c) => {
// ...
// const remixContext = getLoadContext(args)
// return handler(c.req.raw, remixContext)
const remixContext = getLoadContext(args)
return handler(c.req.raw, remixContext instanceof Promise ? await remixContext : remixContext)
}) |
Owner
|
I've updated to check if Can you review this? |
predaytor
approved these changes
Nov 16, 2024
Contributor
Author
|
@yusukebe Thanks for support! Looks good to me! |
Owner
|
Okay! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #21
Support for asynchronous
getLoadContext.The
getLoadContextfunction is already awaited insrc/middleware.tsat line 21.Therefore, we only need to support the type that returns
Promise<AppLoadContext>.※ 英語に自信がないので、日本語でも説明します。
非同期の
getLoadContextのサポート。getLoadContext関数はすでにsrc/middleware.tsの21行目でawaitされています。そのため、
GetLoadContext型がPromise<AppLoadContext>を返せるようにすればよいです。